phpro / grumphp

A PHP code-quality tool

MIT License

4.14k stars 429 forks source link

Add .editorconfig #999

Closed danepowell closed 2 years ago

danepowell commented 2 years ago

Q	A
Branch	master for features and deprecations
Bug fix?	yes/no
New feature?	yes/no
BC breaks?	yes/no
Deprecations?	yes/no
Documented?	yes/no
Fixed tickets	comma-separated list of tickets fixed by the PR, if any

I normally use 2 spaces with PHP, so every time I touch this project I'm fighting default PhpStorm settings 😄

Using editorconfig would make contributors' lives easier by enforcing this automatically.

New Task Checklist:

[ ] Are the dependencies added to the composer.json suggestions?
[ ] Is the doc/tasks.md file updated?
[ ] Are the task parameters documented?
[ ] Is the task registered in the tasks.yml file?
[ ] Does the task contains phpunit tests?
[ ] Is the configuration having logical allowed types?
[ ] Does the task run in the correct context?
[ ] Is the run() method readable?
[ ] Is the run() method using the configuration correctly?
[ ] Are all CI services returning green?

veewee commented 2 years ago

Looks good, thanks!