A dependency has caused the test suite to break

phpspec / prophecy

Highly opinionated mocking framework for PHP 5.3+

MIT License

8.53k stars 242 forks source link

A dependency has caused the test suite to break #305

Open ciaranmcnulty opened 7 years ago

ciaranmcnulty commented 7 years ago

The build on master 22 days ago passed, today it's breaking.

This suggests the break is down to one of our dependencies introducing a change that broke prophecy. Possibly phpspec itself?

More work is needed to figure out which one...

thomasvargiu commented 7 years ago

@ciaranmcnulty @sebastianbergmann

The problem was introduced with PR #298.

Doing a composer update, phpspec/phpspec 2.0.1 is installed, because doesn't require sebastian/exporter.

To use sebastian/recursion-context ^2.0 I think we should use phpspec/phpspec ^3.2.2.

ciaranmcnulty commented 7 years ago

Why did travis not catch it?

thomasvargiu commented 7 years ago

Specs are not compatible with phpspec 2.0 I think. ~~We should make tests with --prefer-lowest to ensure minimum compatibility.~~ (it's a dev dependency)