search

phpspec / prophecy

Highly opinionated mocking framework for PHP 5.3+
MIT License
8.53k stars 241 forks source link

Fix specs for MethodProphecy #434

Closed tkotosz closed 5 years ago

tkotosz commented 5 years ago

Currently when running phpscpec for the MethodProphecy class then I get the following:

$ vendor/bin/phpspec r spec/Prophecy/Prophecy/MethodProphecySpec.php 
                                                                                 0
0 specs
0 examples 
0ms

It seems this happens because a new class is defined before the MethodProphecySpec class which seemingly not allowed.

I have moved that other class to the bottom of the file then the tests started to run but a few of them was failing so I fixed those in this PR.

after the fixes: image

tkotosz commented 5 years ago

php 5 build fixed now, please let me now if there is a better way to fix it :)

tkotosz commented 5 years ago

@stof fixed the PR based on your feedback. Could you please have a look again?

tkotosz commented 5 years ago

squashed commits to prep the PR for merge