Fix methods signatures issue with sebastian/comparator:^1.1

[drupol]

Hi,

There is an issue in sebastian/comparator version 1.1.0 until version 1.2.2.

PHP Fatal error: Declaration of SebastianBergmann\Comparator\DOMNodeComparator::assertEquals($expected, $actual, $delta = 0, $canonicalize = false, $ignoreCase = false) must be compatible with SebastianBergmann\Comparator\ObjectComparator::assertEquals($expected, $actual, $delta = 0, $canonicalize = false, $ignoreCase = false, array &$processed = Array) in /home/pol/dev/git/psrcas/vendor/sebastian/comparator/src/DOMNodeComparator.php on line 149

The issue comes from version 1.1.0 of sebastian/comparator.

See those two files:

• https://github.com/sebastianbergmann/comparator/blob/c484a80f97573ab934e37826dba0135a3301b26a/src/DOMNodeComparator.php#L87
• https://github.com/sebastianbergmann/comparator/blob/c484a80f97573ab934e37826dba0135a3301b26a/src/ObjectComparator.php#L85

Their signature is different and when installing using composer flag --prefer-lowest, it fails.

That issue has been fixed in version 1.2.3 (see commit)

Therefore I propose to raise the minimal version to 1.2.3 instead of 1.1.0.

Link to PR: #452

[drupol]

There is another issue.

If we do this, then when downgrading to sebastian/comparator:1.2.3, this package has also an issue with the signature in ClosureComparator.php.

I'll push a commit to fix this so we can clearly see the tests failing on first commit and tests succeeding on second one.