search

phpspec / prophecy

Highly opinionated mocking framework for PHP 5.3+
MIT License
8.53k stars 241 forks source link

Tentatively support php8 #470

Closed staabm closed 4 years ago

staabm commented 4 years ago

In the process of getting composer/composer ready for php8, see https://github.com/composer/semver/pull/91

alexpott commented 4 years ago

We need to fix the call to $parameter->getClass() and $parameter->isArray() and $parameter->isCallable() in \Prophecy\Doubler\Generator\ClassMirror

These method are deprecated in PHP 8.

staabm commented 4 years ago

I dont plan to continue working on this. feel free to take over this PR

ciaranmcnulty commented 4 years ago

I have a branch that removes the deprecations, waiting to merge #476 first before proceeding as they overlap

GrahamCampbell commented 4 years ago

This PR can be closed, I think?

ciaranmcnulty commented 4 years ago

Thanks for contributing @staabm. Even though it's not merged it helped move the conversation along!