search

phpspec / prophecy

Highly opinionated mocking framework for PHP 5.3+
MIT License
8.53k stars 241 forks source link

Add php8 support #492

Closed Glancu closed 4 years ago

Glancu commented 4 years ago

There are still issues with the deprecated method ReflectionParameter::getClass() but i don't know, how to fix.

DonCallisto commented 4 years ago

I think we need to update phpdocumentor/reflection-docblock to 5.1 (https://github.com/phpspec/prophecy/blob/master/composer.json#L22) and everything should be ok.

Edit: I've just seen that 5.1 still has the same problem. The fix is currently only on master.

Glancu commented 4 years ago

I think we need to update phpdocumentor/reflection-docblock to 5.1 (https://github.com/phpspec/prophecy/blob/master/composer.json#L22) and everything should be ok.

Edit: I've just seen that 5.1 still has the same problem. The fix is currently only on master.

Nice, that's works :smiley:

DonCallisto commented 4 years ago

LGTM. We only should remember to get rid of 5.0-dev when Prophecy will have a new tagged version. Otherwise we could ask for 5.1.1 for reflection-docblock.

stof commented 4 years ago

What is this PR about, considering that #477 is already merged ?

garak commented 4 years ago

@stof the PR you mentioned doesn't add php8 to require section in composer.json

ciaranmcnulty commented 4 years ago

Thanks for the effort but until #482 is fixed and feature freeze has happened, we don't support PHP8

Can you please revert the composer changes? The change to the test looks interesting

garak commented 4 years ago

Thanks for the effort but until #482 is fixed and feature freeze has happened, we don't support PHP8

Uh? Mentioned issue is not fixed and anyway it's not about php8 support. I don't get mention to "feature freeze" either. This is a proposal to support php8 in master branch

ciaranmcnulty commented 4 years ago

The config changes are something I'll do when prophecy is ready. I can't see the logic behind the skipped test - if you want to open a PR with just that in it and an explanation please do

Glancu commented 4 years ago

The config changes are something I'll do when prophecy is ready. I can't see the logic behind the skipped test - if you want to open a PR with just that in it and an explanation please do

Thanks for reply. I fixed all problems, so we can try again with my code add support PHP 8.