phpspec / prophecy

Highly opinionated mocking framework for PHP 5.3+
MIT License
8.53k stars 242 forks source link

Force a specific phpspec hash until it has a PHP8 release #500

Closed ciaranmcnulty closed 4 years ago

ciaranmcnulty commented 4 years ago

Pins to a known good PHP8-supporting phpspec

Also stops nightly build from being an allowed failure. If we merge this, #499 and #495 we should have a passing PHP8 build

stof commented 4 years ago

why not forcing the latest dev-master instead ?

ciaranmcnulty commented 4 years ago

@stof the changes are on 6.2 branch and I couldn't work out how to get that. dev-6.2 did not seem to work

ciaranmcnulty commented 4 years ago

I'd hope this to be a temporary situation. Once Prophecy allows 8.0 (soon) then phpspec can release pretty rapidly I believe