return type not compatible anymore

[maddy2101]

With https://github.com/phpspec/prophecy/commit/f8add3131ec60d8fce8308f2431c4d29b60890cf#diff-4c5e3d292394f5c16c0cd7597bc2dd87 return type handling was changed, and it causes a failure for me. This is the situation:

$mailTransport = $this->prophesize(\Symfony\Component\Mailer\Transport\SendmailTransport::class);

=> PHP Fatal error: Declaration of Double\Symfony\Component\Mailer\Transport\SendmailTransport\P144::setMaxPerSecond(float $rate): Symfony\Component\Mailer\Transport\SendmailTransport must be compatible with Symfony\Component\Mailer\Transport\AbstractTransport::setMaxPerSecond(float $rate): Symfony\Component\Mailer\Transport\AbstractTransport in /srv/bamboo/xml-data/build-dir/CORE-GTN-UTR1PHP721/vendor/phpspec/prophecy/src/Prophecy/Doubler/Generator/ClassCreator.php(49) : eval()'d code on line 2

and this is the explanation: Symfony\Component\Mailer\Transport\AbstractTransport::setMaxPerSecond() defines a return type of self, while prophecy interprets a return type of \Symfony\Component\Mailer\Transport\SendmailTransport

This then fails the eval test. The error is present with the new tag of 1.12.0, but not with 1.11.1.

[ciaranmcnulty]

If this is a dupe I'll keep #502 open and close this one - thanks for reporting

[ciaranmcnulty]

Sorry #502 is a PR so this should be open.

Thanks for the specific git hash - that's very helpful

[ciaranmcnulty]

If you are able to test #504 that would be great

[maddy2101]

Testing in progress.

Thank you very much for this really fast merge and tag. This way we can run our nightly test again, it will tell exactly whether the issue is resolved. I am impressed, very good work, keep it up :+1: :)

Kind regards Anja

[maddy2101]

verified, the failure is gone. Thank you ever so much for that very quick handling.