Is support for hhvm dropped?

TysonAndre commented 2 years ago

I'm not currently using hhvm, but would be useful to clarify this in comments/issue tracker

https://hhvm.com/blog/2018/09/12/end-of-php-support-future-of-hack.html

HHVM 4.0 dropped support for php files in 2019 HHVM did not add support for new functions such as spl_object_id - see #560 (realized I saw a few comments in the codebase about HHVM and was surprised there was never an spl_object_id addition to HHVM)

There are open issues related to hhvm, can they be closed?
Can comments in the codebase related to hhvm be removed
Tests don't seem to target hhvm

stof commented 2 years ago

Yes, we stopped supporting HHVM because we only support PHP and they dropped it. I will clean the issue tracker.

jdreesen commented 2 years ago

There are some references to HHVM in the code, too: https://github.com/phpspec/prophecy/search?q=hhvm

stof commented 2 years ago

The HhvmExceptionPatch should indeed be removed. Do you want to send a PR ?

jdreesen commented 2 years ago

I'm sorry, but I'm very busy at the moment. Maybe @TysonAndre can do it?

phpspec / prophecy

Is support for hhvm dropped? #561