search

phpspec / prophecy

Highly opinionated mocking framework for PHP 5.3+
MIT License
8.53k stars 241 forks source link

Support standalone and nullable types for true, false, and null. #566

Closed kschatzle closed 1 year ago

kschatzle commented 1 year ago

Question in general. Since true isn't a builtin type until PHP8.2, the code that is being mocked shouldn't have true as a standalone type. So how do choose what to prevent via versioning and what not?

kschatzle commented 1 year ago

Hoping I get a comment from the above. As I'm changing a lot of for #535 that may require this type of version checking.

ciaranmcnulty commented 1 year ago

@kschatzle not sure what the question means really? You have the PHP version checks in place that look correct, to me at least

Can you rebase please?

ciaranmcnulty commented 1 year ago

ok I fixed the conflict and fixed an issue with true handling - thanks!