search

phpspec / prophecy

Highly opinionated mocking framework for PHP 5.3+
MIT License
8.53k stars 241 forks source link

Document arguments to willReturn #572

Closed neclimdul closed 1 year ago

neclimdul commented 1 year ago

Fixes #552

neclimdul commented 1 year ago

variadic makes more sense to me but went with the annotation to match similar behavior in Argument::allOf

stof commented 1 year ago

As the min supported version is now PHP 7.2, please use a variadic signature instead (the initial implementation was done with support for PHP 5.3).

stof commented 1 year ago

@neclimdul any chance to update your PR ?

neclimdul commented 1 year ago

@stof rebased and applied the variadic natively. Docs left for phpstan.

stof commented 1 year ago

Thanks @neclimdul