search

phpspec / prophecy

Highly opinionated mocking framework for PHP 5.3+
MIT License
8.53k stars 242 forks source link

Fix the testsuite #600

Closed stof closed 1 year ago

stof commented 1 year ago

As PHPUnit 10+ does not include a builtin Prophecy integration, we should not rely on it to write tests.

Thus, when writing tests for Prophecy itself, it is better if the test shows usages of the Prophecy API instead of hiding it in the PHPunit integration (which would also run additional code to verify predictions, which might make the test confusing).

stof commented 1 year ago

I'm merging this. I will handle the phpstan failure in a separate PR.