search

phpspec / prophecy

Highly opinionated mocking framework for PHP 5.3+
MIT License
8.53k stars 242 forks source link

PHPCS: nullable types PHP 8.4 #630

Closed andypost closed 3 months ago

andypost commented 3 months ago

First part for #624

jrfnl commented 3 months ago

This PR should also fix the new deprecations reported by a optional argument before required ones (which was skipped when the default value was making the type nullable implicitly).

I scanned this branch with PHPCompatibility, which can check for both deprecations and this branch is clean of both of those issues.

Edit: at least it is at this time (when I scanned it).

stof commented 3 months ago

Edit: at least it is at this time (when I scanned it).

It was not the case when I asked for that change, as shown by the static analysis CI job at that time: https://github.com/phpspec/prophecy/actions/runs/10492742258/job/29065879468