phpstan / extension-installer

Composer plugin for automatic installation of PHPStan extensions.
MIT License
399 stars 27 forks source link

composer-plugin-api version question #14

Closed juliangut closed 4 years ago

juliangut commented 4 years ago

I'm facing a problem with Scrutinizer and this package requiring "composer-plugin-api": "^1.1". Have a look here: https://scrutinizer-ci.com/g/juliangut/json-api/inspections/b2ee72d5-7046-4c60-afe2-aee3475ab8bb

Others have face this situation before, such as https://github.com/symfony/thanks/issues/36 It seems it has to do with composer version so no problem with the package

Anyway I've to ask why ^1.1, couldn't a lower requirement be enough? I've no experience with composer plugin system so far

ondrejmirtes commented 4 years ago

Hi, you should upgrade to a newer version of Composer.

This package doesn’t have to be usable by everyone since there’s always an alternative way to enable PHPStan extensions, by manually including them in phpstan.neon. It represents a happy path, a narrow use-case, and I’m fine with that.

On Fri, 20 Sep 2019 at 02:27, Julián Gutiérrez notifications@github.com wrote:

I'm facing a problem with Scrutinizer and this package requiring "composer-plugin-api": "^1.1". Have a look here: https://scrutinizer-ci.com/g/juliangut/json-api/inspections/b2ee72d5-7046-4c60-afe2-aee3475ab8bb

Others have face this situation before, such as symfony/thanks#36 https://github.com/symfony/thanks/issues/36 It seems it has to do with composer version so no problem with the package

Anyway I've to ask why ^1.1, couldn't a lower requirement be enough? I've no experience with composer plugin system so far

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/phpstan/extension-installer/issues/14?email_source=notifications&email_token=AAAZTOCBRCD2UPRNCSXNNWTQKQKF5A5CNFSM4IYRKLN2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HMRUSPA, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAZTOGD2DMW7IIYDIK7GETQKQKF5ANCNFSM4IYRKLNQ .

--

Ondřej Mirtes

juliangut commented 4 years ago

This package doesn’t have to be usable by everyone since there’s always an alternative way to enable PHPStan extensions

Don't get me wrong, I got nothing against that philosophy, I was wondering if that is the lowest dependency version possible

The problem here is with Scrutinizer not updating its composer version, I've no problem locally or in travis for that matter

ondrejmirtes commented 4 years ago

I’m sure you can run composer self-update there beforehand 😊

On Fri, 20 Sep 2019 at 09:34, Julián Gutiérrez notifications@github.com wrote:

This package doesn’t have to be usable by everyone since there’s always an alternative way to enable PHPStan extensions

Don't get me wrong, I got nothing against that philosophy, I was wondering if that is the lowest dependency version possible

The problem here is with Scrutinizer not updating its composer version, I've no problem locally or in travis for that matter

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/phpstan/extension-installer/issues/14?email_source=notifications&email_token=AAAZTOG2FR3APBYQQ4TMYULQKR4JXA5CNFSM4IYRKLN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7F3NYQ#issuecomment-533444322, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAZTOD63JIWU4Z2VSGIPOTQKR4JXANCNFSM4IYRKLNQ .

--

Ondřej Mirtes

github-actions[bot] commented 3 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.