search

phpstan / extension-installer

Composer plugin for automatic installation of PHPStan extensions.
MIT License
399 stars 27 forks source link

Install exported extensions from every composer package type #37

Closed mvorisek closed 2 years ago

mvorisek commented 2 years ago

Phpstan extensions must be ex/importable from every composer package type.

This functionality is already mentioned in the README https://github.com/phpstan/extension-installer/blob/1.1.0/README.md?plain=1#L53

Example usecase: https://github.com/mvorisek/atk4-hintable-mirror package is of standard library type and it provides php libraries together with custom phpstan rules.

ondrejmirtes commented 2 years ago

Phpstan extensions must be ex/importable from every composer package type.

They already are. Your change only lowers the number of entries in the generated config which isn't desirable. What your change does is that if a package is a phpstan-extension but doesn't have the extra.phpstan key, it will not end up in the generated config.

mvorisek commented 2 years ago

Yes, it is, I was doing change across several repos and the repo with phpstan was not using the repo with the exported phpstan extension, sorry about this PR.