search

phpstan / extension-installer

Composer plugin for automatic installation of PHPStan extensions.
MIT License
399 stars 27 forks source link

Compliance with PSR-2 and/or PSR-12? #8

Closed niconoe- closed 5 years ago

niconoe- commented 5 years ago

Hi there, and first of all, thank you for this awesome work!

When I wanted to propose a new pull request, I found that your script is following a coding standard that is not in compliance with the PSR-2 nor the incoming PSR-12.

Is this something you did by choice (to not rely on those PSRs)? On other hand, if you're interested in to follow those standards (and being more strict by continuing to follow your current rules that are not in conflict with PSRs), I can provide a PR for that.

Thanks again

ondrejmirtes commented 5 years ago

Hi, I always welcome improvement one step at a time. This is a very small repo where it doesn't matter, but feel free to open PR with a single new sniff added to phpcs.xml in phpstan/phpstan.

I'm more interested in strict code checking (which was the biggest inspiration for slevomat/coding-standard) rather than following standards, but I'd like to see what you have in mind.

github-actions[bot] commented 3 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.