phpstan / phpdoc-parser

Next-gen phpDoc parser with support for intersection types and generics
MIT License
1.35k stars 61 forks source link

Upgrade to `nikic/php-parser:^5.0` #233

Closed tanerkay closed 8 months ago

tanerkay commented 8 months ago

see https://github.com/nikic/PHP-Parser/blob/master/UPGRADE-5.0.md

notably a php 7.4 version requirement

if we want to retain php 7.2/7.3 support, we could support both v4.0 and v5.0, but given that the main phpstan repo already requires php 8.1, I think this is fine, given the age of php 7.3 (end of life since over 2 years)

ondrejmirtes commented 8 months ago

phpdoc-parser does not depend on nikic/PHP-Parser. It's only in require-dev.

If you're getting an error message about a conflict in Composer, it's not a fault of phpdoc-parser.