phpstan / phpdoc-parser

Next-gen phpDoc parser with support for intersection types and generics
MIT License
1.36k stars 61 forks source link

Support for `@pure-unless-callable-is-impure` #253

Closed staabm closed 2 months ago

staabm commented 2 months ago

required for https://github.com/phpstan/phpstan/issues/11100

ondrejmirtes commented 2 months ago

Pinging some people in the community about an opinion first, stay tuned :)

ondrejmirtes commented 2 months ago

Decided to go for it. Other suggestions similar to how Hack handles things are more general, but very complicated to do right now.

ondrejmirtes commented 2 months ago

Thank you!

hrach commented 2 months ago

What a missed opportunity to name it @pure-iff-callable-is-pure

ondrejmirtes commented 2 months ago

iff is something math nerds use 😂

hrach commented 2 months ago

Maybe an alias? 😇