search

phpstan / phpdoc-parser

Next-gen phpDoc parser with support for intersection types and generics
MIT License
1.35k stars 61 forks source link

Fix IntegrationPrinterWithPhpParserTest #255

Closed staabm closed 1 month ago

staabm commented 1 month ago

since PHPParser 5.3 this integration test fails.

it overlapps with a upstream implemenation of indentation-printing which was added with https://github.com/nikic/PHP-Parser/commit/e50c67b7a94d2d028f8792f462e31ba4ed9f2680

the PR removes the phpdoc-parser custom build indentation printer and re-uses the upstream indentation printer instead.

staabm commented 1 month ago

on my windows box for some reason I cannot fix CS here (creates a lot of unrelated changes). @ondrejmirtes would be great you could fix cs/phpstan-baseline, in case the fix itself works for you

staabm commented 1 month ago

in case we agree on this one, I can have a look at simple-downgrader 2.x

ondrejmirtes commented 1 month ago

Awesome, thank you!

I can have a look at simple-downgrader 2.x

Yes please :)