PHP 7.2 compatibility - Githubissues

phpstan / phpstan-nette

Nette Framework class reflection extension for PHPStan & framework-specific rules

MIT License

100 stars 35 forks source link

PHP 7.2 compatibility #9

Closed xificurk closed 7 years ago

xificurk commented 7 years ago

Fixes #8

It's ugly, but it works... The only way I could get the tests pass under PHP 7.2 was to use string to refer to Nette\Object. Using alias or FQN does not work, because it triggers autoloading during static analysis and an error is thrown due to the Nette\Object code.

ondrejmirtes commented 7 years ago

Hi, thanks for the fix! There's no reason to leave 7.2 in allow_failures, can you remove that so that the build fails if something is wrong on 7.2?

xificurk commented 7 years ago

Done.

ondrejmirtes commented 7 years ago

Thanks! I'm gonna release it now as 0.8.1.