phpstan / phpstan-phpunit

PHPUnit extensions and rules for PHPStan
MIT License
468 stars 46 forks source link

Fixed false positive when covering a global function. #169

Closed mad-briller closed 1 year ago

mad-briller commented 1 year ago

Previously this case wasn't tested and was overlooked as phpstan test data files are namespaced, but this cropped up today during rollout of the rules and so i've had to @covers a php built-in to cover the case in a test

also moved the "doesn't specify anything" test up in the code as it's a fail-fast path, dunno why i put it where i did in the first place, time pressure probably

thanks for your time

ondrejmirtes commented 1 year ago

Thank you!