search

phpstan / phpstan-phpunit

PHPUnit extensions and rules for PHPStan
MIT License
468 stars 46 forks source link

1.3.16 throwing errors on arrays after assertCount #206

Open acbramley opened 8 months ago

acbramley commented 8 months ago

Our automated updates updated to 1.3.16 today and started failing phpstan. Based on the changes from 1.3.15 it's obvious what the issue is.

Our tests do something like this:

    $mails = $this->getMails();
    $this->assertCount(1, $mails);
    $mail = \reset($mails);
    $this->assertStringContainsString('foo', $mail['subject']);

Where getMails returns an array.

And this is throwing errors like Cannot access offset 'subject' on false.

ondrejmirtes commented 8 months ago

Can you put it some dumptType calls to see what's happening with the types? See https://phpstan.org/user-guide/troubleshooting-types#debugging