Addition of rule for cases better represented with assertSameSize() method

o0h commented 6 months ago

This Pull Request enhances the AssertSameWithCountRule in PHPUnit to handle additional use cases. The new rule now checks when both sides of the assertSame are counts, and suggests assertSameSize instead when necessary.

Here is some detail on what has changed:

AssertSameWithCountRule now includes a check for cases where expected value of assertCount is the direct result of count function call.
In these cases, a special assertion function assertSameSize is suggested to compare the sizes of collections rather than using the original assertSame function.

The code changes involve adjustments in method call structures, evaluation of counts and introduction of cases for assertSameSize.

o0h commented 5 months ago

Hi, @ondrejmirtes!

Thanks for the quick feedback! Sorry that it's not passing the CI checks just yet. I'll sort out the issue and let you know once it's ready for review.

I'll be sure to use the bleeding edge flag as you suggested. Just hang tight a little longer!

Best regards,

o0h commented 5 months ago

I have completed the necessary corrections that were of concern. I would appreciate it if you could take a look and check it. Thank you 😃

phpstan / phpstan-phpunit

Addition of rule for cases better represented with assertSameSize() method #207