search

phpstan / phpstan-shim

[DEPRECATED] This repository provides easy way to install PHPStan without the risk of conflicting dependencies.
MIT License
87 stars 15 forks source link

nikic/php-parser dependency #21

Closed michalkleiner closed 6 years ago

michalkleiner commented 6 years ago

If my understanding is correct, does the package, providing a standalone phar executable, need to reference the nikic/php-parser as a replacement dependency?

If so, would it be possible to soften it to ^3 || ^4?

Currently, it's conflicting with SilverStripe framework admin module's requirement of version 3.

michalkleiner commented 6 years ago

I also PR'd it on the other side https://github.com/silverstripe/silverstripe-framework/pull/8281

ondrejmirtes commented 6 years ago

It’s not possible to soften it, v4 is a lot different.

On Tue, 24 Jul 2018 at 06:33, Michal Kleiner notifications@github.com wrote:

I also PR'd ir on the other side silverstripe/silverstripe-framework#8281 https://github.com/silverstripe/silverstripe-framework/pull/8281

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/phpstan/phpstan-shim/issues/21#issuecomment-407277887, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGZuJdr9QMwmDCwcmlyCVURBVlVrOYnks5uJqOFgaJpZM4VcDG4 .

--

Ondřej Mirtes

michalkleiner commented 6 years ago

Ok, no problem. Hopefully, SS will accept the PR at their end which should resolve it. Thanks!