search

phpstan / phpstan-strict-rules

Extra strict and opinionated rules for PHPStan
MIT License
605 stars 48 forks source link

Fixed incorrect branch alias #145

Closed GrahamCampbell closed 2 years ago

ondrejmirtes commented 2 years ago

Hi, what consequences does this have? This is generally needed when you want to have ^1.1 in your composer.json but the thing you want is not yet released. Since I release any merged PRs in extensions immediately, I don't think I need to update these aliases.

GrahamCampbell commented 2 years ago

The problem is that if someone asks for 1.0.* but have their minimum stability set to dev, composer can fetch the code that is actually 1.1.1-dev because the branch alias is wrong.

ondrejmirtes commented 2 years ago

Alright, thanks.

GrahamCampbell commented 2 years ago

My preferred solution here is not use branch alias, and instead name the branches such that packagist can understand them. 1.0, 1.1, 1.2. No master branch, and no branch aliases needed.