search

phpstan / phpstan-strict-rules

Extra strict and opinionated rules for PHPStan
MIT License
607 stars 48 forks source link

Update PHPCS #208

Closed staabm closed 1 year ago

staabm commented 1 year ago

as requested in https://github.com/phpstan/phpstan-strict-rules/pull/206#issuecomment-1475835384

the last PHPCS update in phpstan-src also contains "squizlabs/php_codesniffer": "^3.5.3". should I add it here, too?

ondrejmirtes commented 1 year ago

Yes please 😊

staabm commented 1 year ago

locally I also tried copying the phpcs.xml from the phpstan-src repo.

it works and also changes some styles, but I guess we cannot use it, as the extension repos do not have a rector workflow to enforce php 7.2 compat..?

ondrejmirtes commented 1 year ago

phpcs.xml from phpstan-src cannot be used, extensions don't have a PHAR build step, they're traditional packages.

ondrejmirtes commented 1 year ago

Thank you!