phpstan / phpstan-strict-rules

Extra strict and opinionated rules for PHPStan
MIT License
592 stars 46 forks source link

Disallow offset access on string #218

Open mvorisek opened 1 year ago

mvorisek commented 1 year ago

I propose to add, to strict rules, a rule to reject string offset access like:

$str[$index];
$str[5];

in favor of

substring($str, $index, 1)
substring($str, 5, 1)

The main motivation is to detect wrongly declared types. Currently when $var is declared wrongly as string instead of string[], it is undetected.