search

phpstan / phpstan-symfony

Symfony extension for PHPStan
MIT License
698 stars 89 forks source link

feat: Sync Validor stubs with SF6.1 #356

Closed viviengaetan closed 1 year ago

viviengaetan commented 1 year ago

Fix for #344

Adding method __toString() to Validator Stubs according to real Interface

I added some missing part too but I'm not sure if it can break anything in older Symfony / PHP. I can keep it to only adding method if that's needed

ondrejmirtes commented 1 year ago

Thank you.

VincentLanglet commented 1 year ago

HI @ondrejmirtes,

This (and some other feature maybe) was merge in 1.2.x but doesn't appear in any tags https://github.com/phpstan/phpstan-symfony/releases

And there are some 1.3.x tags, but the default branch of https://github.com/phpstan/phpstan-symfony seems to be 1.2.x.

Does the 1.2.x branch should be merged into 1.3.x, the 1.3.x used as a default and a new tag done or something else ?

Thanks.

ondrejmirtes commented 1 year ago

@VincentLanglet Either I need to do some branch reshuffling, or this will have to wait after PHPStan 1.11 is released this fall.

VincentLanglet commented 1 year ago

@VincentLanglet Either I need to do some branch reshuffling, or this will have to wait after PHPStan 1.11 is released this fall.

Oh, I see https://github.com/phpstan/phpstan-symfony/compare/1.3.2...1.2.x

Your call. I'll ignore my errors until the new release. Thanks for the quick answer