search

phpstan / phpstan-symfony

Symfony extension for PHPStan
MIT License
698 stars 89 forks source link

The constant_hassers not working as constantHassers default of extension.neon always used #364

Open alexander-schranz opened 10 months ago

alexander-schranz commented 10 months ago

The extension is setting:

        constant_hassers: true
        constantHassers: true

in our libraries which we had phpstan update it still uses:

        constant_hassers: true

But this seems not has longer any effects based on the code here:

https://github.com/phpstan/phpstan-symfony/blob/b9e1deda86b1c72eb0fcbf1cee836d71ccaf36bc/src/Symfony/Configuration.php#L26

I think constant_hassers never has any effects as constantHassers is still always true. So this BC Layer seems not to work maybe extension.neon should go with:

        constant_hassers: null
        constantHassers: null

What do you think?