search

phpstan / phpstan-webmozart-assert

PHPStan extension for webmozart/assert
MIT License
162 stars 28 forks source link

Support string assertions resulting in non-empty-string #143

Closed herndlm closed 2 years ago

herndlm commented 2 years ago

Closes https://github.com/phpstan/phpstan-webmozart-assert/issues/129

Brings back what was reverted in https://github.com/phpstan/phpstan-webmozart-assert/pull/89 and steals ideas from https://github.com/phpstan/phpstan-webmozart-assert/pull/128

herndlm commented 2 years ago

I want to check if I can make it report if those functions are called more than once with the same args

herndlm commented 2 years ago

Now it works as I imagined :) I'm gonna add the same double-check-report adaption to phpstan-src with str_contains if possible.

herndlm commented 2 years ago

jfyi in case it was missed - I think this one should be good

ondrejmirtes commented 2 years ago

Really nice!

ondrejmirtes commented 2 years ago

Thank you.