search

phpstan / phpstan-webmozart-assert

PHPStan extension for webmozart/assert
MIT License
165 stars 28 forks source link

Support list type #145

Closed herndlm closed 2 years ago

herndlm commented 2 years ago

This is for after PHPStan 1.9.0 was released :)

ondrejmirtes commented 2 years ago

Nice! Thank you :)

ondrejmirtes commented 2 years ago

On the other hand, this will stop make it work without bleedingEdge? We should test both...

herndlm commented 2 years ago

I can split bleedingEdge tests into a dedicated test class if you prefer that

ondrejmirtes commented 2 years ago

Yes, please do :)

herndlm commented 2 years ago

Second thought was doing it in the same test class but a dedicated bleedingEdge type file. I'll see what works best

ondrejmirtes commented 2 years ago

Needs to be a separate file akin to tests/Type/WebMozartAssert/AssertTypeSpecifyingExtensionTest.php. Because you need to return different getAdditionalConfigFiles.