search

phpstan / phpstan-webmozart-assert

PHPStan extension for webmozart/assert
MIT License
165 stars 28 forks source link

Extract remaining tests #76

Closed herndlm closed 2 years ago

ondrejmirtes commented 2 years ago

Conflicts here. Feel free to do a single PR with all these changes so that there are no more conflicts.

herndlm commented 2 years ago

Rebased this PR, cherry-picking the other stuff in and squashing it into a single commit. This removes the data.php file completely.

I'm just not a 100% happy with the inconsistency of the collection and nullable assertion tests. all assertions can be used with collections and nullables (as in all* and nullOr*) and we have a few tested in collections.php while the even fewer nullable assertions are just next to their "normal" tests. I was thinking of moving collection assertions next do their normal asserts too. Or the other way around (creating a nullable.php). A few of those tests, as we have them right now, should be fine I guess, as they all work the same way. But maybe I'm overthinking the cleanup now :)

herndlm commented 2 years ago

sorry for my impatience, can we merge this? :) I'd love to get the remaining 2 count assertions in afterwards

ondrejmirtes commented 2 years ago

Thank you :)