phpstan / phpstan

PHP Static Analysis Tool - discover bugs in your code without running it!

https://phpstan.org/

MIT License

12.89k stars 879 forks source link

Type alias imports in traits do not work #5091

Closed Seldaek closed 1 year ago

Seldaek commented 3 years ago

Bug report

It appears that type aliases get resolved from the scope of the class they are used in, and not from the trait's main docblock.

Code snippet that reproduces the problem

https://phpstan.org/r/fb90214f-4b8d-4f62-87b9-1680ee2afcfa

Expected output

No error.

phpstan-bot commented 3 years ago

@Seldaek After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
 33: Property Monolog\Handler\Handler::$foo has unknown class Monolog\Processor\Record as its type.
-38: Return typehint of method Monolog\Handler\Handler::foo() has invalid type Monolog\Processor\Record.
+38: Method Monolog\Handler\Handler::foo() has invalid return type Monolog\Processor\Record.
 39: Method Monolog\Handler\Handler::foo() should return Monolog\Processor\Record but returns array<string, string>.

Full report

| Line | Error | |---|---| | 33 | `Property Monolog\Handler\Handler::$foo has unknown class Monolog\Processor\Record as its type.` | | 38 | `Method Monolog\Handler\Handler::foo() has invalid return type Monolog\Processor\Record.` | | 39 | `Method Monolog\Handler\Handler::foo() should return Monolog\Processor\Record but returns array.` |

Ilyes512 commented 2 years ago

I got the same. Should we be able to define types in traits and use them elsewhere or not?

edit:

Defining a @phpstan-type and then using it in the same trait does not work as well. For example: https://phpstan.org/r/bb19adc4-c0cb-4007-bd7c-b727b7faa8ab