search

phpsword / sword-bundle

Modern WordPress development with Symfony
https://getsword.com
MIT License
124 stars 4 forks source link

Added phpdoc and return type #31

Closed kacmedija closed 1 year ago

kacmedija commented 1 year ago

On Symfony 6.3.3 there is a deprecated message: "[info] User Deprecated: Method "Symfony\Component\HttpKernel\Bundle\Bundle::build()" might add "void" as a native return type declaration in the future. Do the same in child class "Williarin\WordpressInteropBundle\WilliarinWordpressInteropBundle" now to avoid errors or add an explicit @return annotation to suppress this message."

williarin commented 1 year ago

Not sure about the 2 latest commits. getenv should give the same result as $_SERVER, even on Apache. Can you give an example of what is expected and the actual result? The best would be to create a new PR for this problem.

kacmedija commented 1 year ago

Sure, I will open a separate PR for that and we can discuss and find a proper solution there

williarin commented 1 year ago

Thank you!