phpsysinfo / phpsysinfo

phpSysInfo: a customizable PHP script that displays information about your system nicely
http://phpsysinfo.github.io/phpsysinfo
GNU General Public License v2.0
1.38k stars 233 forks source link

Packaging into Debian #366

Open williamdes opened 1 year ago

williamdes commented 1 year ago

Hi!

Today I started taking the responsability of https://tracker.debian.org/pkg/phpsysinfo

It's outdated in Debian. I will update it and it's packaging.

I may have questions while packaging. Or not :)

Do you have documentation about apt install phpsysinfo usage ?

Internet has some, but do you have some internal ones? Did someone know about this package?

Do you have some automated tests? I cannot see any form of tests here.

Ref: https://salsa.debian.org/php-team/pear/phpsysinfo

it was maintained by jesusch

namiltd commented 1 year ago

The phpSysInfo app is officially only available on github and sourceforge. All other "installers" were created completely without our knowledge.

williamdes commented 1 year ago

Okay, and what about the tests question ? :)

namiltd commented 1 year ago

The only tests are in the tools folder.

williamdes commented 1 year ago

I wrote some phpunit tests, you can cherry-pick them: https://salsa.debian.org/php-team/pear/phpsysinfo/-/tree/debian/3.4.2-1/debian/tests

I may contribute them back some day

williamdes commented 1 year ago

I also had to add this patch in order to have another path for my tests to find an ini file: https://salsa.debian.org/php-team/pear/phpsysinfo/-/blob/debian/3.4.2-1/debian/patches/Change-the-config-path-to-etc-phpsysinfo-phpsysinfo.ini.patch

namiltd commented 1 year ago

Maybe a better solution would be to symlink phpsysinfo.ini to /etc/phpsysinfo/phpsysinfo.ini? I can add PSI_CONFIG_FILE_PATH support to the code.

williamdes commented 1 year ago

Maybe a better solution would be to symlink phpsysinfo.ini to /etc/phpsysinfo/phpsysinfo.ini? I can add PSI_CONFIG_FILE_PATH support to the code.

This was what was done but it's a complicated workaround that a user can break without noticing And I think it did not even work (I tried the old package before updating to my package)

williamdes commented 1 year ago

In a couple of days the new version will migrate to the testing version (next Debian version)

https://tracker.debian.org/news/1406225/accepted-phpsysinfo-342-1-source-into-unstable/

I think that we can document the Debian package on the phpsysinfo website when I am sure the last version is working

williamdes commented 1 year ago

Ready to be documented

williamdes commented 3 months ago

Hi @namiltd Could you please help me with https://bugs.debian.org/1021030 so I can close it ? Do you intend to update jQuery or can you guarantee all CVEs got patched ?

namiltd commented 3 months ago

The jQuery library is at version 1.12.4 for compatibility with older versions of web browsers. However, this is not the original version, but patched by me on an ongoing basis when any CVEs were found. As for the guarantee, it includes fixes for: CVE_2015_9251 CVE_2019_11358 CVE_2020_11022 and CVE_2020_11023

williamdes commented 3 months ago

Okay, thank you