phpsysinfo / phpsysinfo

phpSysInfo: a customizable PHP script that displays information about your system nicely
http://phpsysinfo.github.io/phpsysinfo
GNU General Public License v2.0
1.38k stars 233 forks source link

Drop old libraries #367

Open williamdes opened 1 year ago

williamdes commented 1 year ago

About this open Debian bug complaining about an old jquery version patched for CVEs: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1021030

Could we agree to drop support for IE and remove old libraries and update jquery?

If yes I can work on this

namiltd commented 1 year ago

PhpSysinfo is designed to display information about as many systems as possible on as many systems as possible. Disabling IE support goes against this premise.

williamdes commented 1 year ago

Okay, thank you for clearing this What is the minimum version of IE you want to support? Is upgrading jquery feasible then?

namiltd commented 1 year ago

IE6 for "dynamic" mode and IE8 for "bootstrap" mode.

williamdes commented 1 year ago

Okay I will find a way to spin up old windows IE for this Any other browser that is complicated to handle?

How do you currently test this compatibility?

namiltd commented 1 year ago

Problems also occur with older versions of safari, firefox, midori and chrome. To maintain compatibility for these browsers, additional css are loaded (from the templates/vendor folder). I test them with portable versions of these browsers and in the case of IE on computers with old versions of Windows.

williamdes commented 1 year ago

Okay, this repository should have a .browserslistrc file to state all supported browsers Can you add it? https://github.com/browserslist/browserslist

namiltd commented 1 year ago

The application can run in three modes: static, dynamic and bootstrap. Each of them has different browser requirements, I have no idea how to define it in .browserslistrc

williamdes commented 1 year ago

The application can run in three modes: static, dynamic and bootstrap. Each of them has different browser requirements, I have no idea how to define it in .browserslistrc

Document the lowest, I think it's best Or put one in directories or use custom names People or tools will understand what you meant And it will be standard documentation that CSS compilers can use for example

namiltd commented 1 year ago

The problem is that the static version works on all browsers even without js. Other versions are more demanding eg bootstrap requires firefox min 3.6.

williamdes commented 1 year ago

The problem is that the static version works on all browsers even without js. Other versions are more demanding eg bootstrap requires firefox min 3.6.

It's probably worth creating .browserslistrc-$mode then

namiltd commented 1 year ago

Good idea. That's what I'll do.

namiltd commented 1 year ago

In https://github.com/phpsysinfo/phpsysinfo/commit/a62d6361b8b20a3c334c8b7a21362cb3b416e850 I have added already tested minimal versions of supported browsers. I will gradually add more browsers.

williamdes commented 1 year ago

In a62d636 I have added already tested minimal versions of supported browsers. I will gradually add more browsers.

Awesome ! 💯