search

phptal / PHPTAL

PHP Template Attribute Language — template engine for XSS-proof well-formed XHTML and HTML5 pages
http://phptal.org
GNU Lesser General Public License v2.1
176 stars 42 forks source link

Question/Composer-dev #14

Closed Potherca closed 10 years ago

Potherca commented 11 years ago

The readme currently makes no mention that PHPTAL can be installed through Composer, also the DEV dependencies mentioned in the README file do not appear in the composer.json file.

Maybe I could patch the readme and composer files to fix this?

kornelski commented 11 years ago

Yes, please do.

Ocramius commented 11 years ago

@potherca could you give it a spin and eventually also run phing via composer on travis builds?

Potherca commented 11 years ago

I gave it a spin on travis and everything is the same as the main branch except for the PHP 5.2 job where it chokes on the Phar (possibly related to the fact that phar support was only available through PECL before PHP5.3).

The main branch has a couple of tests that fail, which is a bit annoying in regards to viewing the build result.

You can find the build at https://travis-ci.org/potherca/PHPTAL/builds/3991468

Phing could be run through composer on travis builds, I guess, we'd just have to a add command to the script section in the .travis.yml file...

Ocramius commented 11 years ago

Phing could be run through composer on travis builds, I guess, we'd just have to a add command to the script section in the .travis.yml file...

@potherca that's what I thought when I was saying "give it a spin" :)

Potherca commented 11 years ago

In that case I will look into that too and add it when I get the time (most likely at the end of this week or in the weekend).

tanakahisateru commented 10 years ago

This issue also can be closed because of #23 and #27 .