phptal / PHPTAL

PHP Template Attribute Language — template engine for XSS-proof well-formed XHTML and HTML5 pages
http://phptal.org
GNU Lesser General Public License v2.1
175 stars 43 forks source link

Non ASCII method name #17

Closed tanakahisateru closed 11 years ago

tanakahisateru commented 11 years ago

Some PHP IDEs (like as PhpStorm) can't parse a non-ASCII method name. They shows it as failure result in running PHPUnit. I prefer to change as below:

diff --git a/tests/UTF8Test.php b/tests/UTF8Test.php
index 149b8b3..04caa8e 100644
--- a/tests/UTF8Test.php
+++ b/tests/UTF8Test.php
@@ -24,7 +24,7 @@ class UTF8Test extends PHPTAL_TestCase
         $this->assertEquals('b',$str[2],"mbstring.func_overload is not supported");
     }

-    function testË()
+    function testUmlaut()
     {
         $src = '<div class="box_title">Kopiëren van een rapport</div>';
         $res = $this->newPHPTAL()->setSource($src)->execute();
Ocramius commented 11 years ago

PR? :)

Ocramius commented 11 years ago

Moved to #18