Closed tanakahisateru closed 10 years ago
This may relates to #14. Would @potherca continue to work?
@tanakahisateru Due to a rather bad case of pneumonia and ensuing health issues I've been out of the running since mid-january. At the moment my health is OK, so pretty soon I should be able to contribute some of my spare time to pick up work on issue #14.
I'll separate the work started in #15 and send pull requests for the individual contributions.
Sorry not to know @potherca, please take care :smiley:
Does this require any file changes in the package itself?
Nope, just a git tag (preferably signed) On 8 Sep 2013 17:29, "porneL" notifications@github.com wrote:
Does this require any file changes in the package itself?
— Reply to this email directly or view it on GitHubhttps://github.com/pornel/PHPTAL/issues/23#issuecomment-24022813 .
I suggest to commit changing the version number in composer.json
before the tag.
https://github.com/pornel/PHPTAL/blob/master/composer.json#L5
That field can be dropped. It is not considered afaik. On 8 Sep 2013 17:52, "Hisateru Tanaka" notifications@github.com wrote:
I suggest to commit changing version number in composer.json before the tag.
https://github.com/pornel/PHPTAL/blob/master/composer.json#L5
— Reply to this email directly or view it on GitHubhttps://github.com/pornel/PHPTAL/issues/23#issuecomment-24023263 .
@Ocramius Oh! http://getcomposer.org/doc/02-libraries.md#specifying-the-version I didn't know that, thanks!
@pornel we just need a stable tag here - were you going for 1.3.0
? If the current version is taggable, I'd suggest doing so :)
That would solve the issue immediately
Closing. Should be handled in #27
Yes, let's go with 1.3.0
Currently PHPTAL package is released only as dev-master via Packagist. But it does not have stable code and users may be confused by difference of each other in the same release name 'master'.
https://packagist.org/packages/phptal/phptal
I suggest to point a version number tag as
1.2.3
to master brach. Then Packagist can take it as new numbered release package.I and my friends want to use PHPTAL by Composer but also want to use a stable version of it. (It also includes HTML5 tag fix.)