search

phptal / PHPTAL

PHP Template Attribute Language — template engine for XSS-proof well-formed XHTML and HTML5 pages
http://phptal.org
GNU Lesser General Public License v2.1
178 stars 42 forks source link

Update CodeWriter.php #30

Closed wabbenhuis closed 10 years ago

wabbenhuis commented 10 years ago

Fixes apache-crash duo many notice errors in large projects.

kornelski commented 10 years ago

Thanks for the pull request, but it fails tests:

Fatal error: Cannot redeclare PHPTAL_Php_CodeWriter::$_indentation in /home/travis/build/pornel/PHPTAL/classes/PHPTAL/Php/CodeWriter.php on line 506

wabbenhuis commented 10 years ago

I'm sorry, my bad.

My current version still had: private $_indent = 0; standing there, the latest version already was corrected to private $_indentation = 0;.

2014-02-10 15:53 GMT+01:00 Kornel notifications@github.com:

Thanks for the pull request, but it fails tests:

Fatal error: Cannot redeclare PHPTAL_Php_CodeWriter::$_indentation in /home/travis/build/pornel/PHPTAL/classes/PHPTAL/Php/CodeWriter.php on line 506

Reply to this email directly or view it on GitHubhttps://github.com/pornel/PHPTAL/pull/30#issuecomment-34639953 .