phptal / PHPTAL

PHP Template Attribute Language — template engine for XSS-proof well-formed XHTML and HTML5 pages
http://phptal.org
GNU Lesser General Public License v2.1
175 stars 43 forks source link

Any plans for dropping PHP < 5.3 support #38

Closed usox closed 2 years ago

usox commented 9 years ago

Hi there

Just a quick question: Do you have any plans dropping the support for php < 5.3 in future releases? I'm going to write a patch (at least I'll try) which add Namespaces and Interfaces which will break the compatibilty to the current supported versions of php (php 5.1.x?).

Potherca commented 9 years ago

It could be worth the combined effort to create a PHPTALv2 for PHP >= 5.3.3. Besides Support for namespaces, this would also allow for the use of Closures.

It would also allow upgrading to PHPUnit 4 (which allows for more precise coverage definitions for the unit test).

kornelski commented 9 years ago

Yes, we shouldn't support PHP versions that are obsolete.

usox commented 9 years ago

So I guess it's PHP5.4 then. Or should we start over with 5.5?

Potherca commented 9 years ago

Given how few backward incompatibilities PHP5.5 has in regards to 5.4, it could be worth having 5.5 as "main" version (bacwards compatibility for 5.4 from 5.5 is rather trival, except for the class contant and yield and finally.

kornelski commented 9 years ago

IMHO:

usox commented 9 years ago

@pornel PHP5.4 EOL is obviously in 2015 so maybe we should consider to skip it? http://php.net/archive/2014.php#id2014-08-14-1

kornelski commented 9 years ago

@usox if you make a pull request with some hot new stuff that requires php5.5, can do :)

usox commented 9 years ago

I will (at laest I'll try :) ).

Should we create a new branch for the coming PRs or should I use the master?

kornelski commented 9 years ago

Please develop features on a branch.

Potherca commented 8 years ago

@Ocramius Do you think we should take a stab at this? Maybe set up a v2 branch?

Ocramius commented 8 years ago

@potherca only if v2 deprecates installation methods that are not composer-based.

If we can switch to composer-only, then we can upgrade PHP version requirements gradually, as it doesn't consist in a BC break (users will simply be given an older compatible version).

If v2 lands with other installation methods, then every PHP version requirement bump will result in a BC break instead :-(

Potherca commented 8 years ago

I am all for composer-only install. I've taken the liberty of summarising what I think need doing for the README file. We could define more things that we think/feel need to be improved and set a v2 milestone?

Ocramius commented 8 years ago

@potherca track everything you want to get done for a v2 in issues, then set the milestone (created v2.0.0) and find people who can get those done for you :)

Ocramius commented 8 years ago

Also: I suggest keeping v2 very minimal (removing features/cleanups, mostly) in order to get some swing for working on new functionality (v2.* or v3). Don't try adding stuff, or you'll be stuck quicker than ever.

Potherca commented 8 years ago

Agreed. The main focus for me would be on cleanup/docs (to get a firm grasp of the current state of things) and removing things that are marked deprecated (either in TAL or in PHP) to be more "future proof".

Having a clean baseline should also help get some more people on board when I start promoting PHPTAL more widely in my personal network...

usox commented 8 years ago

@potherca If you need some help regarding the docs/cleanup, tell me.

Potherca commented 8 years ago

@usox Feel free to comment on issue #41 if you think I missed anything (or have further suggestions).

Potherca commented 2 years ago

@Ocramius Not sure whether we should close this issue (as PHP 5.3 is no longer supported) or rename it to "Start using namespaces" as that seems to be more what this thread is about. Ideas?

Ocramius commented 2 years ago

Let's just close this 👍