Closed usox closed 9 years ago
First of all: thank you for the work thus far @usox !
Other than a few minor pointers this looks good to me. I feel inclined to merge this.
@Ocramius / @Pornel ?
(Also, do we want this to go on master or a v2 branch and integrate later? I think we need to start making that CONTRIBUTING
file...)
@usox @potherca merged and created branch 1.3.x
off of tag 1.3.0
.
master
is 2.x
if you want (we can alias it in a different PR if you prefer so)
Also applied the review comments
I updated the readme and the composer.json according to #41. Also, I removed the build.xml and the phing targets from the Makefile due to dependency problems to PEAR-Packages (FileManager at least). The only used phing target was
tar
which (from what I understand) is/was used to build a release package. Any thoughts about that?