phptal / PHPTAL

PHP Template Attribute Language — template engine for XSS-proof well-formed XHTML and HTML5 pages
http://phptal.org
GNU Lesser General Public License v2.1
175 stars 43 forks source link

Make sure the locales used in the tests are installed in the Travis environment #50

Closed Potherca closed 8 years ago

Potherca commented 8 years ago

As became apparent in #49, "something" changed in the Travis-CI environment that caused the build to break because tests suddenly started failing.

This seemed to have something to do with the locales. Listing all of the locales installed on the Travis machine corroborated this:

$ locale -a
C
C.UTF-8
en_US.utf8
POSIX
pt_BR.utf8
pt_PT.utf8

The most simple solution seemed to be: making sure all of the needed locales were available by explicitly installing them. This can easily be achieved by adding the install commands to the Travis configuration file, in a before_script step.

This pull request does that.

@Ocramius Are we good to merge, or did I miss anything?