search

phptal / PHPTAL

PHP Template Attribute Language — template engine for XSS-proof well-formed XHTML and HTML5 pages
http://phptal.org
GNU Lesser General Public License v2.1
175 stars 43 forks source link

Add .gitattributes to remove unneeded files #54

Closed Slamdunk closed 7 years ago

Potherca commented 7 years ago

Thanks for this!

I totally forgot about ignoring files that are irrelevant for release/deploy scenarios. As Composer also uses .gitattributes, this is a very useful addition in my opinion.

@Ocramius Do you think the Makefile should also be added? And/or possibly others? readme.md seems like a candidate. I'm not sure doc/ is needed. And what about xsd/?

Ocramius commented 7 years ago

@Potherca Makefile: yep, also to be added. The XSD is still needed though, as folks download it locally to validate PHPTAL files manually.

Slamdunk commented 7 years ago

Makefile added

Slamdunk commented 7 years ago

@Potherca to be clear, composer doesn't use .gitattributes, Github do while building the zip file for download, and composer just refers to these zip files

Potherca commented 7 years ago

@Slamdunk Thanks for the clarification. It never hurt to be explicit :smile:

@Ocramius This looks good to merge. Agree?

Ocramius commented 7 years ago

@Potherca go on :-)