search

phptal / PHPTAL

PHP Template Attribute Language — template engine for XSS-proof well-formed XHTML and HTML5 pages
http://phptal.org
GNU Lesser General Public License v2.1
178 stars 42 forks source link

Add PHP 8.2 support, drop PHP 7.4 #90

Closed Slamdunk closed 2 years ago

Slamdunk commented 2 years ago

I admit I've done the minimal effort to get the tests pass because code quality without CSFix & SA tools is a pain.

I'm undecided between answering your change requests with "Ain't nobody got time for that" or "Ok but only with doctrine/coding-standard and psalm at level 6"

Ocramius commented 2 years ago

@Slamdunk I would just make sure we improve what we can, without breaking BC. I've done hundreds of these patches on laminas/: we don't need to refactor anything particular, just the diff lines :)

Ocramius commented 2 years ago

I'll remove the 7.4 pipeline requirement once ready and releasable :+1:

Ocramius commented 2 years ago

Released: https://github.com/phptal/PHPTAL/releases/tag/1.7.0

Thanks @Slamdunk!