BUG Remove private var that is now protected in monolog

phptek / silverstripe-sentry

Flexible Sentry compatible bug aggregation client for Silverstripe applications.

BSD 3-Clause "New" or "Revised" License

12 stars 22 forks source link

BUG Remove private var that is now protected in monolog #18

Closed tractorcow closed 5 years ago

tractorcow commented 5 years ago

Resolves issue where private var crashes on override of existing protected in base

Fatal error: Access level to PhpTek\Sentry\Monolog\Handler\SentryRavenHandler::$logLevels must be protected (as in class Monolog\Handler\RavenHandler) or weaker in /Users/damian.mooyman/Sites/testsite/vendor/phptek/sentry/src/Handler/SentryRavenHandler.php on line 23

tractorcow commented 5 years ago

Awesome thanks @phptek !

phptek commented 5 years ago

Can you confirm the framework version you're using this with? If you can confirm dev-master works with it, I'm happy to increment to a minor relese. Cheers.

tractorcow commented 5 years ago

I've been using framework 4.1 and 4.2 (various projects).

Can you please tag a 2.0.1 with this?

You can see the discussion over at https://github.com/Seldaek/monolog/issues/1216 regards to "is this a bugfix or change" and it feels like it's just a minor bugfix, not requiring a minor version upgrade.

phptek commented 5 years ago

Already done :-)