search

phptek / silverstripe-sentry

Flexible Sentry compatible bug aggregation client for Silverstripe applications.
BSD 3-Clause "New" or "Revised" License
12 stars 22 forks source link

BUG Show actual stacktrace for errors / exceptions #20

Closed tractorcow closed 5 years ago

tractorcow commented 5 years ago

@phptek Sentry had been only ever rendering stack traces for the error handling classes themselves; These are not so useful when trying to diagnose the actual issue. :)

Tested on both fatal errors, as well as exceptions.

Uses the work I did at https://github.com/Seldaek/monolog/pull/1080 to capture non-exception traces as well. :)

tractorcow commented 5 years ago

@phptek I've done a linting review, fixed a few type hints, fixed a bug in RavenClient::getLevel(), and fixed the indentation based on your preference. How does it look now?

phptek commented 5 years ago

Merged. Many thanks @tractorcow

tractorcow commented 5 years ago

Yay, thanks to you!

Now I feel bad about letting my PRs sit around for months when you have a same day turnaround, haha.

phptek commented 5 years ago

LOL. I have standards to maintain seeing as PRs taking too long was the reason I built phptek/sentry instead of pushing PRs to the incumbent's Sentry module.

tractorcow commented 4 years ago

@phptek can we please have a new release to include this fix? thanks.