search

phptek / silverstripe-sentry

Flexible Sentry compatible bug aggregation client for Silverstripe applications.
BSD 3-Clause "New" or "Revised" License
12 stars 22 forks source link

3.0: Bug fixes #28

Closed G-Rath closed 4 years ago

G-Rath commented 4 years ago

Finally had a chance to play around w/ the 3.0 branch.

Found a few bugs that caused errors, which we sorted. The biggest thing however is that the SentryClientAdaptor class was renamed to SentryAdaptor, meaning that the config needs to be updated when moving to 3.0

For now I've just put a note in the README, and updated the config examples, but it might be nicer to revert the renaming.

G-Rath commented 4 years ago

@phptek just an fyi github supports merge via squash, as well as disabling non-squashing merges :)

phptek commented 4 years ago

Nice. I'm used to Gitlab that uses the same feature.

G-Rath commented 4 years ago

I've not actually used gitlabs before tbh, but it's not surprising. You can also suggest a change, which lets the author just hit "accept", and github commits it, which can be super useful for straightforward changes like your config suggestion.

I've set log_level to be WARNING, and squashed. Let me know if there are any other changes you'd like :)