search

phptek / silverstripe-sentry

Flexible Sentry compatible bug aggregation client for Silverstripe applications.
BSD 3-Clause "New" or "Revised" License
12 stars 22 forks source link

Log level configuration for 2.0.x #29

Closed halles closed 4 years ago

halles commented 4 years ago

Added configuration for minimal log level config on 2.0.x

Parameter name is the same as what has been implemented for 3.0.x

Update README accordingly.

phptek commented 4 years ago

OK, I ran a few tests and it works well - thanks! I have added a few comments inline. Once you've fixed those up, can you please squash all your commits into a single one and force-push the feature-branch? Cheers :-)

halles commented 4 years ago

@phptek this is failing to build do to a silverstripe cms recipe not being available anymore. This tag seems to be two years old. Would you like me to patch that pipeline?

phptek commented 4 years ago

Sure! Just needs to be the minimum version that composer will work with.

phptek commented 4 years ago

I'm still not sure under what circumstances one might run this task. Can you explain? If it's still required, it should probably be restricted to running only with a permissioned user.

halles commented 4 years ago

@phptek this is not the task 🤔

halles commented 4 years ago

@phptek could you rerun this pipeline? It should be ready to merge now :)

halles commented 4 years ago

@phptek got confused between PRs.

This PR is both the log_level config availability and the task to test successful Sentry connection. Basically is to test that Sentry is working before the app shoot an exception.