search

phptek / silverstripe-sentry

Flexible Sentry compatible bug aggregation client for Silverstripe applications.
BSD 3-Clause "New" or "Revised" License
12 stars 22 forks source link

getData() doesn't work #32

Closed phptek closed 4 years ago

phptek commented 4 years ago

SentryAdaptor::getData() isn't called from anywhere other than tests. It should be used to augment a Sentry record with additional data e.g. when sending "manual" logs without Exceptions being thrown.

The module works A-OK without this, but if I recall, in 2.x getData() created additional Sentry "tags" along the top of its UI.

TODO: Review behaviour from 2.x and ensure this feature is needed and patch as required.

phptek commented 4 years ago

Closing. getData() isn't used. Removed and refactored in 3.0